bugfix(Android): zIndex issues on android #8061 #8136
Merged
Conversation
1 task
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling React Native's DebuggingOverlay in touch event delegation to prevent it from incorrectly intercepting touch events. The main change refactors touch coordinate checking to skip DebuggingOverlay views when determining if a touch event is inside the actual React content.
- Introduced a new
isInsideView()method that iterates through ReactView children and filters out DebuggingOverlay containers - Updated
handleDown()to use the newisInsideView()method instead of directly checking coordinates - Added comprehensive test mocks to simulate the React view hierarchy including DebuggingOverlay
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| OverlayTouchDelegate.kt | Refactored touch coordinate checking logic to skip DebuggingOverlay views when determining if touch events are inside React content |
| OverlayTouchDelegateTest.java | Updated test setup to mock the complete React view hierarchy including DebuggingOverlay for testing the new filtering behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
merteroglu
approved these changes
Nov 2, 2025
d4vidi
reviewed
Nov 2, 2025
Collaborator
d4vidi
left a comment
d4vidi
left a comment
There was a problem hiding this comment.
Some questions and requests... please read 🙏🏻
…zindex-blocks-touches
d4vidi
approved these changes
Nov 3, 2025
d4vidi
deleted the
bugfix/8061-overlay-with-a-view-with-stylezindex-blocks-touches
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8061